[fix](compile) fix macOS compilation error due to missing f_frsize in statfs#60753
Open
airborne12 wants to merge 1 commit intoapache:masterfrom
Open
[fix](compile) fix macOS compilation error due to missing f_frsize in statfs#60753airborne12 wants to merge 1 commit intoapache:masterfrom
airborne12 wants to merge 1 commit intoapache:masterfrom
Conversation
… statfs macOS statfs struct does not have f_frsize member (it is Linux-specific). Use f_bsize directly on macOS via #ifdef __APPLE__ guard. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Member
Author
|
run buildall |
TPC-H: Total hot run time: 29115 ms |
TPC-DS: Total hot run time: 184499 ms |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Problem Summary:
macOS
statfsstruct does not have thef_frsizemember — it is Linux-specific (statvfson Linux hasf_frsize, but macOSstatfsonly hasf_bsize). This causes a compilation error on macOS:The fix adds
#ifdef __APPLE__guards to usef_bsizedirectly on macOS, while keeping the originalf_frsizelogic on Linux.Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)