[thirdparty] (buildscript) use PKG_CONFIG_LIBDIR instead of PKG_CONFIG_PATH#60752
Open
SwingURM wants to merge 1 commit intoapache:masterfrom
Open
[thirdparty] (buildscript) use PKG_CONFIG_LIBDIR instead of PKG_CONFIG_PATH#60752SwingURM wants to merge 1 commit intoapache:masterfrom
SwingURM wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
SwingURM
changed the title
Author
|
run buildall |
TPC-H: Total hot run time: 28471 ms |
TPC-DS: Total hot run time: 184583 ms |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Author
|
run p0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
When compiling hyperscan, the container's behavior is to give up compiling hscollider because it cannot find pcre.
On my local machine, PKG_CONFIG_PATH (which is set in the script) does not prevent pkg-config from searching system libs. Thus, CMake's pkg_check_modules finds pcre and tries to compile hscollider, but fails due to mixing system's libc (linker errors).
However, on my local machine,
Error:
Solution
Use PKG_CONFIG_LIBDIR instead of PKG_CONFIG_PATH. PKG_CONFIG_PATH appends to the default search path, causing CMake to find the system's pcre. Using PKG_CONFIG_LIBDIR overrides the default search path and only searches in the specified directory. All relevant .pc files are present in this path.
Modifying CMake's related variables may also solve this problem.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)