branch-4.0: [bugfix](k8s) fix Log4jConfig class loading before Config.init in console mode #60531#60750
Open
github-actions[bot] wants to merge 1 commit intobranch-4.0from
Open
branch-4.0: [bugfix](k8s) fix Log4jConfig class loading before Config.init in console mode #60531#60750github-actions[bot] wants to merge 1 commit intobranch-4.0from
github-actions[bot] wants to merge 1 commit intobranch-4.0from
Conversation
…sole mode (#60531) When running FE in console mode, `Log4jConfig.foreground = true` was executed before `Config.init()`, which triggers Log4jConfig class loading too early. The static block in Log4jConfig calls `getXmlConfByStrategy()` reading `Config.log_rollover_strategy`, but fe.conf has not been loaded yet, so it always gets the default value "age" regardless of the actual config. In daemon mode this is not an issue because Log4jConfig is first referenced at `initLogging()` which is called after `Config.init()`. Fix: move the `Log4jConfig.foreground = true` assignment to after `Config.init()` and before `Log4jConfig.initLogging()`, ensuring the static block sees the correct config values from fe.conf.
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
|
run buildall |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #60531