[fix](txn) Set transaction status to COMMITTED only after commit info is fully populated#60749
Open
zclllyybb wants to merge 1 commit intoapache:masterfrom
Open
[fix](txn) Set transaction status to COMMITTED only after commit info is fully populated#60749zclllyybb wants to merge 1 commit intoapache:masterfrom
zclllyybb wants to merge 1 commit intoapache:masterfrom
Conversation
… is fully populated Move setTransactionStatus(COMMITTED) to after idToTableCommitInfos population in both commitTransaction methods. This prevents PublishVersionDaemon from seeing COMMITTED status with empty commit info, as it checks status without synchronized(transactionState) lock.
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 28626 ms |
TPC-DS: Total hot run time: 182664 ms |
Contributor
FE Regression Coverage ReportIncrement line coverage |
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #59990
Problem Summary:
Move setTransactionStatus(COMMITTED) to after idToTableCommitInfos population in both commitTransaction methods. This prevents PublishVersionDaemon from seeing COMMITTED status with empty commit info, as it checks status without synchronized(transactionState) lock.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)