feat: Optimize hash util for MapArray#20179
Open
jonathanc-n wants to merge 2 commits intoapache:mainfrom
Open
Conversation
Contributor
Author
|
@Jefffrey I'm not sure to also do this optimization for I was thinking of doing a take() operation on the children array using the offsets. but I don't know if its worth the allocation overhead. What exact strategy were you thinking of for union array? |
xudong963
reviewed
Feb 6, 2026
Member
xudong963
left a comment
xudong963
left a comment
There was a problem hiding this comment.
Do we have a micro benchmark for the PR?
Or do you need me to enable the general benchmark in datafusion?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Reduce the irrelevant data being used to hash for
MapArrayWhat changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?