feat: impl handle_child_pushdown_result for UnionExec#20145
Open
haohuaijin wants to merge 8 commits intoapache:mainfrom
Open
feat: impl handle_child_pushdown_result for UnionExec#20145haohuaijin wants to merge 8 commits intoapache:mainfrom
handle_child_pushdown_result for UnionExec#20145haohuaijin wants to merge 8 commits intoapache:mainfrom
Conversation
haohuaijin
commented
Feb 4, 2026
haohuaijin
commented
Feb 4, 2026
adriangb
reviewed
Feb 4, 2026
Contributor
Author
|
Thanks for your reviews @adriangb , i add the slt test case for reproduce. |
adriangb
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
see #20144
What changes are included in this PR?
This PR impl
handle_child_pushdown_resultforUnionExec, for any case, the filter will always pushdown to UnionExecUnionExec needs specialized filter pushdown handling when children have heterogeneous pushdown support. Without this, when some children support pushdown and others don't, the default behavior would leave FilterExec above UnionExec, re-applying filters to outputs of all children—including those that already applied the filters via pushdown. This specialized implementation adds FilterExec only to children that don't support pushdown, avoiding redundant filtering and improving performance.
Are these changes tested?
yes, add two test cases
Are there any user-facing changes?