Open
Conversation
This patch adds a support for delete statement with limit planning. An inner table scan is wrapped with a limit in this case. e.g.: ``` query TT explain delete from t1 limit 10 ---- logical_plan 01)Dml: op=[Delete] table=[t1] 02)--Limit: skip=0, fetch=10 03)----TableScan: t1 physical_plan 01)CooperativeExec 02)--DmlResultExec: rows_affected=0 ```
Contributor
|
Thanks again @askalt |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
We support
DELETE LIMITquery and it would be good to port our fork patch to the upstream.What changes are included in this PR?
This patch adds a support for delete statement with limit planning. An inner table scan is wrapped with a limit in this case. e.g.:
Are these changes tested?
Covered with SLT.
Are there any user-facing changes?
Now queries with limited deletion are successfully planned, instead of returning not-supported error.