Skip to content

Fix panic on incomplete REGEXP/MATCH expressions in SQLite dialect #2197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iffyio merged 2 commits into from
Feb 7, 2026
Merged

Fix panic on incomplete REGEXP/MATCH expressions in SQLite dialect #2197

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d980943
Fixed panic
LucaCappelletti94 Feb 5, 2026
991a506
Merge branch 'main' into crash-sqlite
LucaCappelletti94 Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/dialect/sqlite.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,10 @@ impl Dialect for SQLiteDialect {
] {
if parser.parse_keyword(keyword) {
let left = Box::new(expr.clone());
let right = Box::new(parser.parse_expr().unwrap());
let right = Box::new(match parser.parse_expr() {
Ok(expr) => expr,
Err(e) => return Some(Err(e)),
});
return Some(Ok(Expr::BinaryOp { left, op, right }));
}
}
Expand Down
4 changes: 4 additions & 0 deletions tests/sqlparser_sqlite.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -602,6 +602,10 @@ fn test_regexp_operator() {
}
);
sqlite().verified_only_select(r#"SELECT count(*) FROM messages WHERE msg_text REGEXP '\d+'"#);

// Should return an error, not panic
assert!(sqlite().parse_sql_statements("SELECT 1 REGEXP").is_err());
assert!(sqlite().parse_sql_statements("SELECT 1 MATCH").is_err());
}

#[test]
Expand Down