Linstor fix host picking #12047
Merged
Linstor fix host picking #12047
+55
−46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems instead of returning a unsuccessful answer it is better to throw a CloudRuntimeException for error handling.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 4.20 #12047 +/- ##
============================================
+ Coverage 16.18% 16.23% +0.05%
- Complexity 13305 13379 +74
============================================
Files 5657 5657
Lines 498459 498958 +499
Branches 60492 60557 +65
============================================
+ Hits 80694 81025 +331
- Misses 408783 408900 +117
- Partials 8982 9033 +51
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
@blueorangutan package |
|
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15718 |
abh1sar
reviewed
Jan 12, 2026
...n/java/org/apache/cloudstack/storage/datastore/driver/LinstorPrimaryDataStoreDriverImpl.java
Show resolved
Hide resolved
...n/java/org/apache/cloudstack/storage/datastore/driver/LinstorPrimaryDataStoreDriverImpl.java
Show resolved
Hide resolved
Before it was possible that a Host was picked for the primary storage that was not even part of cluster, now we only consider hosts from either the same cluster or same zone depending on primary storage settings.
rp-
force-pushed
the
linstor-4.20-fix-host-picking
branch
from
1e9040f to
150be1c
Compare
abh1sar
approved these changes
Jan 12, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before it was possible that a Host was picked for the primary storage
that was not even part of cluster, now we only consider hosts
from either the same cluster or same zone depending on primary storage
settings.
Also improve cleanup code on
copyAsyncoperations.Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
Hyperconverge and non hyperconverge Linstor cluster tested.
How did you try to break this feature and the system with this change?