Skip to content

fix Sensitive Data Exposure Through Exception Logging in OVM Hypervis… #12032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
YLChen-007 wants to merge 3 commits into
base: 4.20
Choose a base branch
from
Open

fix Sensitive Data Exposure Through Exception Logging in OVM Hypervis… #12032

YLChen-007 wants to merge 3 commits into from
+1 −1

Conversation

@YLChen-007
Copy link
Contributor

@YLChen-007 YLChen-007 commented Nov 8, 2025

This PR fixes Sensitive Data Exposure Through Exception Logging in OVM Hypervisor Configuration. #12031

DaanHoogland
DaanHoogland approved these changes Nov 10, 2025
View reviewed changes
Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@DaanHoogland DaanHoogland added this to the 4.20.3 milestone Nov 10, 2025
@codecov
Copy link

codecov bot commented Nov 10, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 16.23%. Comparing base (750290b) to head (c8554aa).

Files with missing lines Patch % Lines
...java/com/cloud/ovm/hypervisor/OvmResourceBase.java 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               4.20   #12032      +/-   ##
============================================
- Coverage     16.23%   16.23%   -0.01%     
+ Complexity    13378    13375       -3     
============================================
  Files          5657     5657              
  Lines        498932   498932              
  Branches      60552    60552              
============================================
- Hits          81016    80992      -24     
- Misses       408882   408906      +24     
  Partials       9034     9034
Flag Coverage Δ
uitests 4.00% <ø> (ø)
unittests 17.09% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DaanHoogland DaanHoogland linked an issue Nov 12, 2025 that may be closed by this pull request
Sensitive Data Exposure Through Exception Logging in OVM Hypervisor Configuration #12031
Open
abh1sar
abh1sar approved these changes Dec 31, 2025
View reviewed changes
Copy link
Collaborator

@abh1sar abh1sar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@DaanHoogland
Copy link
Contributor

DaanHoogland commented Jan 6, 2026

@YLChen-007 , this code will be deprecated, but it is low risk so let’s merge . (the ovm plugin is about to be deprecated)

@DaanHoogland
Copy link
Contributor

DaanHoogland commented Jan 6, 2026

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Jan 6, 2026

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@YLChen-007
Copy link
Contributor Author

YLChen-007 commented Jan 6, 2026

@YLChen-007 , this code will be deprecated, but it is low risk so let’s merge . (the ovm plugin is about to be deprecated)
I got it.
Thank your response.

@blueorangutan
Copy link

blueorangutan commented Jan 6, 2026

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✖️ debian ✔️ suse15. SL-JID 16267

@DaanHoogland
Copy link
Contributor

DaanHoogland commented Jan 6, 2026

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Jan 6, 2026

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Jan 6, 2026

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✖️ debian ✔️ suse15. SL-JID 16272

@DaanHoogland
Copy link
Contributor

DaanHoogland commented Jan 6, 2026

ubuntu build issue with maven...

sureshanaparti
sureshanaparti approved these changes Jan 6, 2026
View reviewed changes
Copy link
Contributor

@sureshanaparti sureshanaparti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@blueorangutan
Copy link

blueorangutan commented Jan 7, 2026

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✖️ debian ✔️ suse15. SL-JID 16279

cyl-auth and others added 3 commits January 7, 2026 10:14
@cyl-auth @DaanHoogland
fix Sensitive Data Exposure Through Exception Logging in OVM Hypervis…
b38fe2a 
…or Configuration
@DaanHoogland @abh1sar
extra ‘)’ in log.
9129866 
Co-authored-by: Abhisar Sinha <63767682+abh1sar@users.noreply.github.com>
@DaanHoogland @sureshanaparti
remove non-descriptive part
c8554aa 
Co-authored-by: Suresh Kumar Anaparti <sureshkumar.anaparti@gmail.com>
@DaanHoogland DaanHoogland force-pushed the my-fix-420-remove-OVM-exception-sensitive-info branch from 1cca507 to c8554aa Compare January 7, 2026 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@sureshanaparti sureshanaparti sureshanaparti approved these changes

+1 more reviewer

@abh1sar abh1sar abh1sar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

component:logging

Projects

None yet

Milestone

4.20.3

Development

Successfully merging this pull request may close these issues.

Sensitive Data Exposure Through Exception Logging in OVM Hypervisor Configuration

6 participants

@YLChen-007 @DaanHoogland @blueorangutan @sureshanaparti @abh1sar @cyl-auth