Conversation
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Contributor
Author
|
@weizhouapache @nvazquez @DaanHoogland @rohityadavcloud can you please review once? |
shwstppr
commented
Feb 5, 2024
nvazquez
reviewed
Feb 5, 2024
| Between versions 4.17.x, 4.18.0 and 4.18.1, KVM volume snapshot backups were | ||
| not full snapshots and they rely on the snapshots on the primary storage. | ||
| To prevent any loss of data, care must be taken during revert operation and | ||
| it must be ensured that the source primary storage snapshot file is present |
Contributor
There was a problem hiding this comment.
Perhaps we can add more explicit checks on this part on how to find the file from database?
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Contributor
Author
|
@blueorangutan docbuild |
|
@shwstppr a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress. |
|
QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/381. (QA-JID 207) |
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Member
|
Overall LGTM two remarks: |
Contributor
Author
|
@blueorangutan docbuild |
|
@shwstppr a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress. |
|
QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/381. (QA-JID 208) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes for 4.19.0.0 changes
📚 Documentation preview 📚: https://cloudstack-documentation--381.org.readthedocs.build/en/381/