Open
Conversation
There was a problem hiding this comment.
Hi, @andr-sokolov welcome!🎊 Thanks for taking the effort to make our project better! 🙌 Keep making such awesome contributions!
leborchuk
approved these changes
Dec 30, 2025
Contributor
leborchuk
left a comment
There was a problem hiding this comment.
Tests ic_gpcontrib and ic_deb_gpcontrib are green.
LGTM
my-ship-it
reviewed
Dec 30, 2025
| "gpcontrib/gp_sparse_vector:installcheck", | ||
| "gpcontrib/gp_toolkit:installcheck"] | ||
| "gpcontrib/gp_toolkit:installcheck", | ||
| "gpcontrib/gp_internal_tools:installcheck"] |
Contributor
Author
There was a problem hiding this comment.
@my-ship-it Do you suggest to remove changes in this file, because the test is run from build-cloudberry.yml too?
Member
There was a problem hiding this comment.
If any test failed, I think we can see the regression diffs in the ic-gpcontrib workflow, just like this:
be22ade to
76c3d77
Compare
Member
|
Hi @andr-sokolov could you please resolve conflicts and rebase your PR? |
76c3d77 to
104b5d1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.