[CALCITE-7412] Redis test failed on higher versions of macOS #4789
+72
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihaibudiu
reviewed
Feb 7, 2026
| // On newer versions of macOS, the temporary directory /var/folders does not | ||
| // support executing binary files with a .app extension, which prevents Redis | ||
| // from starting. To ensure Redis runs correctly, the redis-server binary is | ||
| // uniformly renamed to edis-server. |
| // uniformly renamed to edis-server. | ||
| String executableName = "redis-server"; | ||
| File command = new File(tmpDir, executableName); | ||
| System.out.println("Executing " + command.getAbsolutePath()); |
Contributor
There was a problem hiding this comment.
Is this print supposed to be here?
mihaibudiu
approved these changes
Feb 7, 2026
xiedeyantu
force-pushed
the
CALCITE-7412
branch
from
050eab5 to
d02a6cf
Compare
Member
Author
|
@mihaibudiu Thank you for your detailed review. I have corrected both issues. |
|
xiedeyantu
added
LGTM-will-merge-soon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See CALCITE-7412