[yaml] : fix create different type elements issue

[derrickaw]

fix #37577

---

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

• Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
• Update CHANGES.md with noteworthy changes.
• If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

[gemini-code-assist]

Summary of Changes

Hello @derrickaw, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the Create transform within Apache Beam's YAML capabilities to gracefully handle inputs comprising a blend of primitive values and dictionary objects. The primary goal is to ensure robust and consistent schema inference by normalizing these mixed types into a uniform dictionary format, thereby preventing potential runtime errors or unexpected schema definitions. This change improves the flexibility and reliability of defining data pipelines using YAML.

Highlights

• Mixed Type Handling in Create Transform: The Create transform in Beam YAML now correctly handles inputs that contain a mix of primitive types and dictionaries. Previously, such mixed inputs could lead to inconsistent schema inference.
• Schema Normalization: Implemented logic within the create function to normalize mixed input elements. Primitive elements are now wrapped into dictionaries with an 'element' key, ensuring all elements are dictionaries for consistent schema inference.
• New Test Cases: Added a new YAML pipeline test case and a corresponding Python unit test to validate the correct behavior of the Create transform with mixed type inputs.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• sdks/python/apache_beam/yaml/tests/create.yaml
  • Added a new pipeline test case demonstrating the Create transform with mixed type elements (primitives and dictionaries) and asserting the expected output schema.
• sdks/python/apache_beam/yaml/yaml_provider.py
  • Modified the create function to detect and normalize mixed input types (dictionaries and non-dictionaries) by wrapping primitive elements into dictionaries with an 'element' key.
  • Ensured that this normalization only occurs when a mix of types is present, preserving existing behavior for homogeneous inputs.
• sdks/python/apache_beam/yaml/yaml_provider_unit_test.py
  • Introduced a new unit test class YamlProvidersCreateTest.
  • Added test_create_mixed_types to verify the Create transform's ability to process mixed primitive and dictionary inputs correctly, asserting the resulting Row structure.

Activity

• The pull request was opened by derrickaw to address issue [Bug]: Beam YAML 'Create' transform crashes on mixed primitive and dictionary elements due to schema inconsistency #37577.
• The changes include modifications to the YAML provider logic and the addition of new test cases to validate the fix.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[derrickaw]

Run Python PreCommit 3.13

[derrickaw]

/gemini review

[gemini-code-assist]

Code Review

This pull request fixes an issue with creating elements of different types in YAML by normalizing them before schema inference. The changes are logical and well-tested. I've included one suggestion to improve the efficiency of the type-checking logic, which could be beneficial for large datasets.

[derrickaw]

Run Python_Runners PreCommit 3.11

[github-actions]

Assigning reviewers:

R: @tvalentyn for label python.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

• stop reviewer notifications - opt out of the automated review tooling
• remind me after tests pass - tag the comment author after tests pass
• waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

[tvalentyn]

pickle_library should be already cloudpickle by default

[derrickaw]

removed, thanks

[tvalentyn]

should some of this comment content be part of the docstring?

[tvalentyn]

(lmk if you plan changes here, otherwise I will merge)

[derrickaw]

just updated, thanks

[tvalentyn]

i thought whether we should mention this in changes.md. looking at the issue, this is not a breaking change, correct?

[derrickaw]

i thought whether we should mention this in changes.md. looking at the issue, this is not a breaking change, correct?

It shouldn't be, as an error should be thrown with existing code.