Skip to content

Optimize data size estimation for proto coder. #37584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robertwb merged 2 commits into from
Feb 13, 2026
+6 −0
Merged

Optimize data size estimation for proto coder. #37584

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0adeae8
Optimize data size estimation for proto coder.
robertwb Feb 12, 2026
9a1dedf
Use existing _get_nested_size utility.
robertwb Feb 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions sdks/python/apache_beam/coders/coder_impl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,6 +316,9 @@ def decode(self, encoded):
proto_message.ParseFromString(encoded) # This is in effect "ParsePartial".
return proto_message

def estimate_size(self, value, nested=False):
return self._get_nested_size(value.ByteSize(), nested)


class DeterministicProtoCoderImpl(ProtoCoderImpl):
"""For internal use only; no backwards-compatibility guarantees."""
Expand All @@ -335,6 +338,9 @@ def encode(self, value):
def decode(self, value):
return self.proto_plus_type.deserialize(value)

def estimate_size(self, value, nested=False):
return self._get_nested_size(type(value).pb(value).ByteSize(), nested)


UNKNOWN_TYPE = 0xFF
NONE_TYPE = 0
Expand Down
Loading