[SpannerIO] Add low-latency configuration in Spanner Change Streams#37580
[SpannerIO] Add low-latency configuration in Spanner Change Streams#37580stankiewicz wants to merge 2 commits intoapache:masterfrom
Conversation
Summary of ChangesHello @stankiewicz, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the Spanner Change Streams connector by introducing explicit low-latency configuration options and improving its resilience against pipeline stalls. The changes allow users to fine-tune polling and heartbeat intervals for sub-second latency requirements and ensure continuous processing even when only heartbeat records are present, leading to a more robust and performant data streaming solution. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
…cdcTimeIncrement` and `heartbeatMillis`; add a low-latency option; and update heartbeat record action to explicitly resume processing.
de7c40b to
fc4cf57
Compare
|
r: @scwhittle |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
|
r: @chenxuesdu maybe you could take a look at from perspective of change streams |
|
Also adding @tianz101 @jiangzzhu for change streams |
| // Return (now + 2 mins) as the end timestamp for reading change streams. This is only used if | ||
| // users want to run the connector forever. If the end timestamp is reached, we will resume | ||
| // Return (now + config duration) as the end timestamp for reading change | ||
| // streams. This is only |
| throw new IllegalArgumentException("Unknown record type " + record.getClass()); | ||
| } | ||
|
|
||
| if (maybeContinuation.isPresent()) { |
There was a problem hiding this comment.
I think that all previous continuations have been stops. I think that there is an edge case when resuming here we have to confirm is not a potential issue. The timestamp of where we are going to resume processing is updated when we process the heartbeat. However it is possible there is multiple records with the same timestamp. In general the restriction tracker tryClaim makes sure that all records that had the same timestamp are processed to handle this. However with this early return I think if it is possible that a heartbeat has the same timestamp as a record we could exit this processing before we process the record and on resuming we would start past that record.
It seems unlikely that would be the case but I'd rather get some explicit confirmation or handle that.
Perhaps an easy way to handle it would be to notify the interruptor that we want to interrupt when we get a heartbeat. And then it already internally handles ensuring all the timestamps of the same value are processed. We could change the actions to return just a boolean indicating whether or not to stop since the continuation itself isn't well supported.
| * Heartbeat interval for all change stream queries. | ||
| * | ||
| * <p>Be careful when changing this interval, as it needs to be less than the checkpointing | ||
| * interval in Dataflow. Otherwise, if there are no records within checkpoint intervals, the |
There was a problem hiding this comment.
I previously changed the sdk to ignore runner-initiated splits until tryClaim was made. This ensures some progress per scheduling.
...ava/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerIO.java
Outdated
Show resolved
Hide resolved
...ava/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerIO.java
Show resolved
Hide resolved
…dd a low-latency option;
9f61bbd to
0d9b313
Compare
Background / Goal: The default polling intervals and heartbeat configurations for Spanner change streams (2-minute time increments and 2-second heartbeats) are too slow for pipelines aiming for sub-second latencies. This PR introduces a low-latency mode and improves robustness for continuous change streams reading.
Changes Made:
withLowLatency()
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.