Skip to content

fix(python): Register all output pcollections of a transform rather than only ones that happened to be accessed in DoOutputsTuple #37556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hjtran wants to merge 2 commits into
base: master
Choose a base branch
from
+7 −5
Open

fix(python): Register all output pcollections of a transform rather than only ones that happened to be accessed in DoOutputsTuple #37556

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e5b3971
Fix DoOutputsTuple composite output registration for lazily-populated…
hjtran Feb 9, 2026
c7880b9
Remove separate regression test; existing test covers the fix
hjtran Feb 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions sdks/python/apache_beam/pipeline.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -843,9 +843,10 @@ def apply(

assert isinstance(result.producer.inputs, tuple)
if isinstance(result, pvalue.DoOutputsTuple):
for tag, pc in list(result._pcolls.items()):
all_tags = [result._main_tag] + list(result._tags)
for tag in all_tags:
if tag not in current.outputs:
current.add_output(pc, tag)
current.add_output(result[tag], tag)
continue

# If there is already a tag with the same name, increase a counter for
Expand Down
7 changes: 4 additions & 3 deletions sdks/python/apache_beam/pipeline_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1646,9 +1646,10 @@ def expand(self, pcoll):
all_applied_transforms[xform.full_label] = xform
current_transforms.extend(xform.parts)
xform = all_applied_transforms['Split Sales']
# Confirm that Split Sales correctly has two outputs as specified by
# ParDo.with_outputs in ParentSalesSplitter.
assert len(xform.outputs) == 2
# Confirm that Split Sales correctly has three outputs: the main
# (untagged) output plus the two tagged outputs specified by
# ParDo.with_outputs in ParentSalesSplitter.
assert len(xform.outputs) == 3


if __name__ == '__main__':
Expand Down
Loading