[C++] Harden synthetic OOM tests for mimalloc#49282
Open
k8ika0s wants to merge 1 commit intoapache:mainfrom
Open
[C++] Harden synthetic OOM tests for mimalloc#49282k8ika0s wants to merge 1 commit intoapache:mainfrom
k8ika0s wants to merge 1 commit intoapache:mainfrom
Conversation
|
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format? or See also: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #49280
Summary
This PR makes synthetic OOM unit tests allocator-stable when mimalloc is active.
It updates:
cpp/src/arrow/buffer_test.cccpp/src/arrow/memory_pool_test.hProblem
These tests intentionally request extremely large allocations to force
OutOfMemory.Using near-
maxbounds can hit allocator-specific fatal behavior (especially with mimalloc)before Arrow returns a normal OOM status, making tests environment-dependent.
What changed
ResizeOOMandTestOOM, detect mimalloc backend andGTEST_SKIP()synthetic OOM assertions.1 << 48(256 TB), which is still impossible in practice but avoids extreme allocator boundary paths.-63) andASSERT_RAISES(OutOfMemory, ...)logic for non-mimalloc backends.Why this approach
Risk / Compatibility