Skip to content

Update Stackdriver docstrings to Cloud Monitoring #61635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
shahar1 merged 1 commit into from
Feb 10, 2026
Merged

Update Stackdriver docstrings to Cloud Monitoring #61635

shahar1 merged 1 commit into from
Feb 10, 2026

Conversation

@KamranImaaz
Copy link
Contributor

@KamranImaaz KamranImaaz commented Feb 8, 2026 •
edited by shahar1
Loading

replaces: #61032
related: #61009

Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)
  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@KamranImaaz KamranImaaz requested a review from shahar1 as a code owner February 8, 2026 12:13
@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels Feb 8, 2026
@KamranImaaz
Copy link
Contributor Author

KamranImaaz commented Feb 8, 2026

CI is green and The changes can be cleanly merged.

SameerMesiah97
SameerMesiah97 approved these changes Feb 8, 2026
View reviewed changes
Copy link
Contributor

@SameerMesiah97 SameerMesiah97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. It’s just a docstring change.

@eladkal
Copy link
Contributor

eladkal commented Feb 9, 2026

cc @shahar1 should we generate new classes with the new name and deprecate the old ones?

@shahar1
Copy link
Contributor

shahar1 commented Feb 10, 2026

cc @shahar1 should we generate new classes with the new name and deprecate the old ones?

Eventually yes, added a link to the issue I created about it in this PR's description

@shahar1 shahar1 changed the title Modify docstrings by adding cloud monitoring in stackdriver file Update Stackdriver docstrings to Cloud Monitoring Feb 10, 2026
@shahar1 shahar1 merged commit b859726 into apache:main Feb 10, 2026
90 checks passed
@KamranImaaz KamranImaaz deleted the fix-docstrings-stackdriver.py branch February 10, 2026 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shahar1 shahar1 shahar1 approved these changes

+1 more reviewer

@SameerMesiah97 SameerMesiah97 SameerMesiah97 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area:providers provider:google Google (including GCP) related issues

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@KamranImaaz @eladkal @shahar1 @SameerMesiah97