Add run type legend tooltip to grid view #61632
Open
+56
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreahlert
requested review from
bbovenzi,
choo121600,
guan404ming,
pierrejeambrun,
ryanahamilton,
shubhamraj-git and
vatsrahul1001
as code owners
boring-cyborg
bot
added
area:translations
area:UI
Member
|
Could you help attach screenshot for your changes, thanks! |
| "toggleGroup": "Toggle group" | ||
| } | ||
| }, | ||
| "legend": "Run Type Legend" |
Member
There was a problem hiding this comment.
Nit:
Suggested change
| "legend": "Run Type Legend" | |
| "runTypeLegend": "Run Type Legend" |
Member
There was a problem hiding this comment.
Your not using it, it should be above the run types description
|
|
||
| const runTypes: Array<DAGRunResponse["run_type"]> = ["scheduled", "manual", "backfill", "asset_triggered"]; | ||
|
|
||
| export const GridLegend = () => { |
Member
There was a problem hiding this comment.
Suggested change
| export const GridLegend = () => { | |
| export const RunTypeLegend = () => { |
| return ( | ||
| <Tooltip | ||
| content={ | ||
| <Box> |
Member
There was a problem hiding this comment.
here add "Run Type Legend"
pierrejeambrun
added
the
backport-to-v3-1-test
Member
|
Updated the PR description. Its part of #28737 but there are other items on the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #28737.
This adds a small info icon (ℹ) next to the existing keyboard shortcut icon in the grid view. On hover, it displays a tooltip showing each DAG run type with its corresponding icon:
The previous attempt (#51736) was closed due to performance issues with Chakra tooltips on large grids and bad UX with truncated markdown notes. This implementation keeps things simple by reusing the existing
Tooltipcomponent (same as the keyboard shortcut tooltip) and theRunTypeIconcomponent already used throughout the grid.Note indicators were left out of scope since the grid API responses (
GridRunsResponse,LightGridTaskInstanceSummary) don't include note fields.Changes:
GridLegendcomponent inlayouts/Details/Grid/GridLegend.tsxGridLegendtoPanelButtons.tsx(grid-only section)legendtranslation key todag.json