docs: fix misleading timetable variable example#61596
Open
Ratasa143 wants to merge 2 commits intoapache:mainfrom
Open
docs: fix misleading timetable variable example#61596Ratasa143 wants to merge 2 commits intoapache:mainfrom
Ratasa143 wants to merge 2 commits intoapache:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR updates the best practices documentation to fix a confusing example in
the Timetables section.
The previous example accessed Airflow Variables inside a Timetable, which is
evaluated during DAG parsing. Doing this at parse time can lead to performance
issues or even cause the DAG processor to fail. The example has been updated to
avoid database access, and a note has been added to clarify the expected and safe
usage.
Why is this change needed?
The existing example no longer reflects current best practices and could
mislead users into writing unsafe DAG code.
Related issue
Fixes #61497