Fix missing translation keys for blocking dependencies in UI (#61314)#61366
Fix missing translation keys for blocking dependencies in UI (#61314)#61366guan404ming merged 4 commits intoapache:mainfrom
Conversation
There was a problem hiding this comment.
Thanks for the PR! However, I think the current changes do not seem to address the root cause.
The issue is that the BlockingDeps component needs to load the dag namespace to access the keys in airflow-core/src/airflow/ui/public/i18n/locales/en/dag.json.
To fix this, please revert the changes in this PR and instead modify BlockingDeps.tsx as follows:
- Update the hook to load the namespace:
const { t: translate } = useTranslation("dag");
- Remove the
dag.prefix from the keys (since we are already in the dag namespace):
// Change this:
{translate("dag.blockingDeps.title")}
// To this:
{translate("blockingDeps.title")}
(Please apply this pattern to dependency and reason headers as well.)
|
Thank you so much for letting me know I will fix this ASAP. |
- Revert changes to global i18n config - Load 'dag' namespace specifically in BlockingDeps component - Update translation keys to match namespace context
|
@RoyLee1224 I hope The following commit will solve this issue |
airflow-core/src/airflow/ui/src/components/Clear/TaskInstance/ClearTaskInstanceDialog.tsx
Outdated
Show resolved
Hide resolved
guan404ming
left a comment
There was a problem hiding this comment.
One question left, otherwise looks good.
airflow-core/src/airflow/ui/src/components/Clear/TaskInstance/ClearTaskInstanceDialog.tsx
Outdated
Show resolved
Hide resolved
|
@guan404ming I have change its state to true and i hope this solves the current issue. |
|
Thanks! |
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
… UI (#61314) (#61366) * Fix missing translation keys for task Scheduling Blocking Dependency * Fix i18n namespace usage in BlockingDeps - Revert changes to global i18n config - Load 'dag' namespace specifically in BlockingDeps component - Update translation keys to match namespace context * fix: defaults preventRunningTask to true * Update i18n config (cherry picked from commit 6dbb6a8) Co-authored-by: Saksham Singhal <sakshamsinghal2020@gmail.com>
… UI (#61314) (#61366) (#61638) * Fix missing translation keys for task Scheduling Blocking Dependency * Fix i18n namespace usage in BlockingDeps - Revert changes to global i18n config - Load 'dag' namespace specifically in BlockingDeps component - Update translation keys to match namespace context * fix: defaults preventRunningTask to true * Update i18n config (cherry picked from commit 6dbb6a8) Co-authored-by: Saksham Singhal <sakshamsinghal2020@gmail.com>
…61314) (apache#61366) * Fix missing translation keys for task Scheduling Blocking Dependency * Fix i18n namespace usage in BlockingDeps - Revert changes to global i18n config - Load 'dag' namespace specifically in BlockingDeps component - Update translation keys to match namespace context * fix: defaults preventRunningTask to true * Update i18n config
This PR resolves an issue where translation keys for "Blocking Dependencies" in the Task Instance Details panel were missing (e.g.,
dag.blockingDeps.title,dag.blockingDeps.dependency), displaying raw keys instead of the localized text.The
dagandtaskstranslation files existed in the locales directory but were not registered in the i18n configuration (config.ts), preventing them from being loaded. This change adds both namespaces to the configuration to ensure the translations are applied correctly.closes: #61314
Was generative AI tooling used to co-author this PR?
No