Add advisory lock before creating label in create/merge operation#2178
Add advisory lock before creating label in create/merge operation#2178mdianjun wants to merge 2 commits intoapache:masterfrom
Conversation
|
@MuhammadTahaNaveed PTAL, thanks. |
0ef0e7c to
7f9edf8
Compare
7f9edf8 to
0319625
Compare
|
@MuhammadTahaNaveed Can you check if this is a new CI issue? |
|
@mdianjun Can you rebase (against the master) and force push this PR? We had to fix the CI that was causing build issues. |
0319625 to
cfab37d
Compare
Have rebased it. |
@mdianjun As this fixes a purported issue, can you provide an example showing this issue? Additionally, can you provide regression tests for it? edit: Why only merge and not create? |
cfab37d to
76895cc
Compare
@jrgemignani Create operation should be fixed as well, I missed it. I add a python script in regress test. |
f9fef54 to
9d2d11b
Compare
|
@MuhammadTahaNaveed Is this something we need to add/fix? Or,... |
When merging nodes or edges concurrently, there is label with the same name created by different session.
However, checking whether the label exists cannot be guaranteed consistency. This commit add an advisory lock
to ensure creating label is serial.