Open
Conversation
*Total -- 505.16kb -> 472.41kb (6.48%) /docs/articles/Architecture Diagram (github readme) (2).jpg -- 252.58kb -> 236.21kb (6.48%) /docs/assets/aden-architecture-diagram.jpg -- 252.58kb -> 236.21kb (6.48%) Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com>
ap-dev-github
pushed a commit
that referenced
this pull request
Feb 2, 2026
Changes based on Copilot AI review (3 issues): 1. Increased thread join timeout (Issue #1): - Changed from 2 to 5 seconds - Made proportional to cleanup timeout - Defined as class constant _THREAD_JOIN_TIMEOUT 2. Handle asyncio.CancelledError explicitly (Issue adenhq#2): - Added separate except clause for CancelledError - Logs specific warning for cancelled cleanup - Re-raises CancelledError as per asyncio best practices - Added for both session and stdio_context cleanup 3. Increased cleanup timeout to match connection timeout (Issue adenhq#3): - Changed from 5 to 10 seconds (matches _connect_stdio timeout) - Defined as class constant _CLEANUP_TIMEOUT - Prevents incomplete cleanup with slow MCP servers
ap-dev-github
pushed a commit
that referenced
this pull request
Feb 2, 2026
Changes based on Copilot AI review (2 issues): 1. Thread join timeout was shorter than cleanup timeout (Issue #1): - Changed _THREAD_JOIN_TIMEOUT from 5 to 12 seconds - Must be >= cleanup timeout (10s) plus buffer for loop.stop() - Prevents thread abandonment during active cleanup 2. Added detailed comment for redundant None assignments (Issue adenhq#2): - Explained why we set _session/_stdio_context to None even if _cleanup_stdio_async() already did it - Documents the safety cases: timeout, failure, skip, cancellation - Makes code intent clear for future maintainers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Beep boop. Your images are optimized!
Your image file size has been reduced by 6% 🎉
Details
📝 docs |
repo | 🙋🏾 issues | 🏪 marketplace
~Imgbot - Part of Optimole family