docs($mdMenu): add documentation for $mdMenu#11649
docs($mdMenu): add documentation for $mdMenu#11649codymikol wants to merge 1 commit intoangular:masterfrom
Conversation
Splaktar
left a comment
There was a problem hiding this comment.
Thank you for adding this. It would be nice to also link the references to the service in https://material.angularjs.org/latest/api/directive/mdMenu to this service page similar to
material/src/components/virtualRepeat/virtual-repeater.js
Lines 20 to 21 in ecf1705
|
Please change |
|
Just bumping this to get your attention 😄 It would be nice to get this into |
|
I'll try to make these changes soon 🐔 |
|
I took a bit of a break from writing software over the past few weeks, I'll try and take a look at this over this coming week. 🐔 |
|
Just a reminder that this only needs some minor tweaks before we can get it in. |
currently there is no documentation. Fixes: angular#11610
65746b8 to
8325af7
Compare
|
@codymikol thank you for rebasing this. Do you think that you will have time to address the review feedback soon? |
|
I finally had some time and after looking at it I realized that I'm pretty much documenting the directive usage in the service docs. I spent some time trying to wrap my head around using the actual service itself and it is definitely a different process entirely. Hopefully I'll be able to take some time and play around with the actual service in a codepen this week until I feel confident enough to write the documentation for its usage. |
currently there is no documentation.
Fixes: #11610
PR Checklist
Please check that your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Docs for $mdMenu are missing
Issue Number: #11610
What is the new behavior?
Added documentatiion
Does this PR introduce a breaking change?
Other information