fix(ng-dev): improve failure message for repository rule violation #3348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephperrott
force-pushed
the
handle-repository-ruleset-failure
branch
from
faa3644 to
a071bf4
Compare
kirjs
approved these changes
Jan 5, 2026
| ) { | ||
| Log.error(' ✘ Repository Rule Violation. This typically indicates that you are not'); | ||
| Log.error(' currently a member of the expected group for merge permissions in this'); | ||
| Log.error(' repository.'); |
Contributor
There was a problem hiding this comment.
do we want to be more specific here, and mention caretaking
Member
Author
There was a problem hiding this comment.
I can mention caretaking. Its just slightly confused/altered by situations when repos don't use a caretaker only to merge. But I can update to include mention of caretaking groups.
kirjs
added
action: merge
When a merge fails due to a repository rule violation, we provide a failure message pointing to our group membership based access for merging.
josephperrott
force-pushed
the
handle-repository-ruleset-failure
branch
from
a071bf4 to
c2608dd
Compare
Member
Author
|
This PR was merged into the repository. The changes were merged into the following branches:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a merge fails due to a repository rule violation, we provide a failure message pointing to our group membership based access for merging.