Skip to content

perf(material/table): Use text-align: start instead of descendent dir… #32585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
kseamon wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

perf(material/table): Use text-align: start instead of descendent dir… #32585

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 21 additions & 16 deletions src/material/table/table.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,10 @@ $fallbacks: m3-table.get-tokens();

@mixin _cell-border {
border-bottom-color: token-utils.slot(
table-row-item-outline-color, $fallbacks, rgba(0, 0, 0, 0.12));
table-row-item-outline-color,
$fallbacks,
rgba(0, 0, 0, 0.12)
);
border-bottom-width: token-utils.slot(table-row-item-outline-width, $fallbacks, 1px);
border-bottom-style: solid;
}
Expand All @@ -39,12 +42,8 @@ $fallbacks: m3-table.get-tokens();
.mdc-data-table__cell {
box-sizing: border-box;
overflow: hidden;
text-align: left;
text-align: start;
text-overflow: ellipsis;

[dir='rtl'] & {
text-align: right;
}
}

.mdc-data-table__cell,
Expand Down Expand Up @@ -87,7 +86,10 @@ $fallbacks: m3-table.get-tokens();
height: token-utils.slot(table-footer-container-height, $fallbacks, 52px);
color: token-utils.slot(table-row-item-label-text-color, $fallbacks, rgba(0, 0, 0, 0.87));
font-family: token-utils.slot(
table-footer-supporting-text-font, $fallbacks, (Roboto, sans-serif));
table-footer-supporting-text-font,
$fallbacks,
(Roboto, sans-serif)
);
line-height: token-utils.slot(table-footer-supporting-text-line-height, $fallbacks);
font-size: token-utils.slot(table-footer-supporting-text-size, $fallbacks, 14px);
font-weight: token-utils.slot(table-footer-supporting-text-weight, $fallbacks);
Expand All @@ -103,11 +105,7 @@ $fallbacks: m3-table.get-tokens();
text-overflow: ellipsis;
overflow: hidden;
outline: none;
text-align: left;

[dir='rtl'] & {
text-align: right;
}
text-align: start;

.mdc-data-table__row:last-child > & {
border-bottom: none;
Expand All @@ -131,15 +129,22 @@ $fallbacks: m3-table.get-tokens();
// MDC table rows are styled with a top border, whereas our legacy flex table styles rows with
// a bottom border. Remove the bottom border style from the rows and let MDC display its top
// border.
mat-row.mat-mdc-row, mat-header-row.mat-mdc-header-row, mat-footer-row.mat-mdc-footer-row {
mat-row.mat-mdc-row,
mat-header-row.mat-mdc-header-row,
mat-footer-row.mat-mdc-footer-row {
border-bottom: none;
}

// Cells need to inherit their background in order to overlap each other when sticky.
// The background needs to be inherited from the table, tbody/tfoot, row, and cell.
.mat-mdc-table tbody, .mat-mdc-table tfoot, .mat-mdc-table thead,
.mat-mdc-cell, .mat-mdc-footer-cell,
.mat-mdc-header-row, .mat-mdc-row, .mat-mdc-footer-row,
.mat-mdc-table tbody,
.mat-mdc-table tfoot,
.mat-mdc-table thead,
.mat-mdc-cell,
.mat-mdc-footer-cell,
.mat-mdc-header-row,
.mat-mdc-row,
.mat-mdc-footer-row,
.mat-mdc-table .mat-mdc-header-cell {
background: inherit;
}
Expand Down
Loading