Skip to content

fix(@angular/cli): renamed files by their new path in the schematic workflow #32385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alan-agius4 merged 2 commits into from
Jan 29, 2026
Merged

fix(@angular/cli): renamed files by their new path in the schematic workflow #32385

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ccd5ff9
fix(@angular/cli): renamed files by their new path in the schematic w…
alan-agius4 Jan 28, 2026
5106af3
refactor(@angular/cli): remove file extension filtering from Prettier…
alan-agius4 Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions packages/angular/cli/src/command-builder/utilities/schematic-workflow.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,10 +55,14 @@ export function subscribeToWorkflow(
logs.push(`${colors.yellow('DELETE')} ${eventPath}`);
files.add(eventPath);
break;
case 'rename':
logs.push(`${colors.blue('RENAME')} ${eventPath} => ${removeLeadingSlash(event.to)}`);
files.add(eventPath);
case 'rename': {
const newFilename = removeLeadingSlash(event.to);

logs.push(`${colors.blue('RENAME')} ${eventPath} => ${newFilename}`);
files.add(newFilename);

break;
}
}
});

Expand Down
32 changes: 2 additions & 30 deletions packages/angular/cli/src/utilities/prettier.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,29 +9,12 @@
import { execFile } from 'node:child_process';
import { readFile } from 'node:fs/promises';
import { createRequire } from 'node:module';
import { dirname, extname, join } from 'node:path';
import { dirname, join } from 'node:path';
import { promisify } from 'node:util';

const execFileAsync = promisify(execFile);
let prettierCliPath: string | null | undefined;

/**
* File types that can be formatted using Prettier.
*/
const fileTypes: ReadonlySet<string> = new Set([
'.md',
'.ts',
'.html',
'.js',
'.mjs',
'.cjs',
'.json',
'.css',
'.less',
'.scss',
'.sass',
]);

/**
* Formats files using Prettier.
* @param cwd The current working directory.
Expand Down Expand Up @@ -59,20 +42,9 @@ export async function formatFiles(cwd: string, files: Set<string>): Promise<void
return;
}

const filesToFormat: string[] = [];
for (const file of files) {
if (fileTypes.has(extname(file))) {
filesToFormat.push(file);
}
}

if (!filesToFormat.length) {
return;
}

await execFileAsync(
process.execPath,
[prettierCliPath, '--write', '--no-error-on-unmatched-pattern', ...filesToFormat],
[prettierCliPath, '--write', '--no-error-on-unmatched-pattern', ...files],
{
cwd,
shell: false,
Expand Down