fix(macos): Fix image attachment not displaying in chat input#145
Open
doscode-kr wants to merge 1 commit intoandrepimenta:mainfrom
Open
fix(macos): Fix image attachment not displaying in chat input#145doscode-kr wants to merge 1 commit intoandrepimenta:mainfrom
doscode-kr wants to merge 1 commit intoandrepimenta:mainfrom
Conversation
## Problem
When users selected images on macOS, the file path did not appear
in the chat input field due to:
1. **Duplicate case statement** (script.ts:2099-2106)
- JavaScript switch had two 'imagePath' cases
- Only the last matching case executes
- First (correct) handler was never executed
2. **Data structure mismatch** (extension.ts:1956-1959)
- Backend sent: {type: 'imagePath', path: '/path'}
- Frontend expected: {type: 'imagePath', data: {filePath: '/path'}}
- Frontend couldn't find the data → silent failure
## Solution
- **Removed duplicate case statement** in script.ts
- Deleted lines 2099-2106
- Only correct handler (lines 1979-2006) remains
- **Unified data structure** in extension.ts
- Changed to send {data: {filePath}} format
- Matches frontend expectation
- Consistent with other message types
## Testing
Tested in Extension Development Host (F5):
- ✅ Click image button → Finder opens
- ✅ Select single image → Path appears in chat input
- ✅ Select multiple images → All paths appear
- ✅ Cancel selection → No errors
## Impact
- **Users**: macOS users can now attach images successfully
- **Code Quality**: Removed code duplication, unified data structure
- **Compatibility**: No breaking changes
## Files Changed
- src/script.ts: Remove duplicate case (-11 lines)
- src/extension.ts: Fix data structure (+4, -1 lines)
Author
|
This fixes #102 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When users selected images on macOS, the file path did not appear in the chat input field due to:
Duplicate case statement (script.ts:2099-2106)
Data structure mismatch (extension.ts:1956-1959)
Solution
Removed duplicate case statement in script.ts
Unified data structure in extension.ts
Testing
Tested in Extension Development Host (F5):
Impact
Files Changed