Adding further aie4 shim test support #895

hlaccabu · 2025-12-03T21:22:25Z

No description provided.

Copilot

Pull request overview

This PR extends AIE4 support in the shim test suite by introducing a new debug buffer type (XRT_BO_USE_UC_DEBUG) and broadening test coverage from AIE2-specific to general AIE platform support. The changes enable debug buffer operations to work correctly on AIE4 devices while maintaining backward compatibility with AIE2.

Introduced XRT_BO_USE_UC_DEBUG buffer type for AIE4 debug operations
Extended test coverage from AIE2-only to all AIE platforms for several test cases
Updated buffer creation logic to conditionally use appropriate debug flags based on device type

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
test/shim_test/shim_test.cpp	Conditionally selects debug buffer flags based on AIE4 detection and broadens test filters from AIE2-specific to general AIE support
src/shim/buffer.cpp	Adds mapping for new XRT_BO_USE_UC_DEBUG buffer type to firmware debug buffer type

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/shim/buffer.cpp

xdavidz

With this, can we get a pass when run "shim_test" without any index number?

Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 7 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

test/shim_test/io_test.cpp

test/shim_test/hwctx.h

Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

test/shim_test/io_test.cpp

test/shim_test/hwctx.h

hlaccabu · 2026-01-06T23:31:31Z

With this, can we get a pass when run "shim_test" without any index number?

Currently yes, but there are a few more tests that I think I can enable with minimal changes before we merge.

Copilot

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

test/shim_test/io_test.cpp

hlaccabu · 2026-01-07T23:58:39Z

With this, can we get a pass when run "shim_test" without any index number?

Yes to this question on silicon, 38 tests passing.

hlaccabu · 2026-01-08T18:33:27Z

retest this please

Copilot

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

test/shim_test/io_test.cpp

Signed-off-by: Hayden Laccabue <hlaccabu@amd.com>

Copilot

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

test/shim_test/io_test.cpp

src/shim/umq/hwq.cpp

Signed-off-by: Hayden Laccabue <hlaccabu@amd.com>

hlaccabu requested a review from xdavidz December 3, 2025 21:22

hlaccabu added the do-not-merge label Dec 3, 2025

Copilot AI review requested due to automatic review settings December 3, 2025 21:22

Copilot AI reviewed Dec 3, 2025

View reviewed changes

src/shim/buffer.cpp Show resolved Hide resolved

xdavidz reviewed Dec 6, 2025

View reviewed changes

hlaccabu added the multi-repo label Dec 18, 2025

hlaccabu force-pushed the shim branch from 4fa9d38 to db21bc3 Compare December 18, 2025 22:34

hlaccabu force-pushed the shim branch from db21bc3 to e0c0e71 Compare January 6, 2026 00:33

Copilot AI review requested due to automatic review settings January 6, 2026 00:33

Copilot AI reviewed Jan 6, 2026

View reviewed changes

amd deleted a comment from Copilot AI Jan 6, 2026

hlaccabu force-pushed the shim branch from e0c0e71 to d638ff6 Compare January 6, 2026 23:19

Copilot AI review requested due to automatic review settings January 6, 2026 23:25

hlaccabu force-pushed the shim branch from d638ff6 to ee5a16e Compare January 6, 2026 23:25

Copilot AI reviewed Jan 6, 2026

View reviewed changes

test/shim_test/io_test.cpp Outdated Show resolved Hide resolved

test/shim_test/io_test.cpp Outdated Show resolved Hide resolved

test/shim_test/hwctx.h Show resolved Hide resolved

hlaccabu force-pushed the shim branch from ee5a16e to 60b5c2c Compare January 7, 2026 01:07

hlaccabu removed the multi-repo label Jan 7, 2026

Copilot AI review requested due to automatic review settings January 7, 2026 23:57

hlaccabu force-pushed the shim branch from 60b5c2c to 6af2da8 Compare January 7, 2026 23:57

hlaccabu removed the do-not-merge label Jan 7, 2026

Copilot AI reviewed Jan 7, 2026

View reviewed changes

test/shim_test/io_test.cpp Outdated Show resolved Hide resolved

test/shim_test/io_test.cpp Outdated Show resolved Hide resolved

test/shim_test/io_test.cpp Outdated Show resolved Hide resolved

hlaccabu force-pushed the shim branch from 6af2da8 to 183c049 Compare January 8, 2026 00:01

Copilot AI review requested due to automatic review settings January 8, 2026 19:58

hlaccabu force-pushed the shim branch from 183c049 to 92a8188 Compare January 8, 2026 19:58

Copilot AI reviewed Jan 8, 2026

View reviewed changes

test/shim_test/io_test.cpp Outdated Show resolved Hide resolved

hlaccabu requested a review from xdavidz January 8, 2026 20:16

hlaccabu force-pushed the shim branch from 92a8188 to 5ab25a9 Compare January 8, 2026 20:49

hlaccabu added the do-not-merge label Jan 8, 2026

hlaccabu added 3 commits January 8, 2026 19:53

Adding further aie4 shim test support

6ce257b

Signed-off-by: Hayden Laccabue <hlaccabu@amd.com>

Remove umq_tests, covered by xrt_test + vadd in shim_test

623d474

Signed-off-by: Hayden Laccabue <hlaccabu@amd.com>

Creating shim io test support for npu3 full elf flow

3a1f2ed

Signed-off-by: Hayden Laccabue <hlaccabu@amd.com>

Copilot AI review requested due to automatic review settings January 9, 2026 03:56

hlaccabu force-pushed the shim branch from 5ab25a9 to fbe0825 Compare January 9, 2026 03:56

Copilot AI reviewed Jan 9, 2026

View reviewed changes

test/shim_test/io_test.cpp Outdated Show resolved Hide resolved

test/shim_test/io_test.cpp Outdated Show resolved Hide resolved

src/shim/umq/hwq.cpp Outdated Show resolved Hide resolved

amd deleted a comment from Copilot AI Jan 9, 2026

Add cmd bo restore header in umq shim

480be1b

Signed-off-by: Hayden Laccabue <hlaccabu@amd.com>

hlaccabu force-pushed the shim branch from fbe0825 to 480be1b Compare January 9, 2026 04:02

hlaccabu requested a review from maxzhen January 9, 2026 04:03

hlaccabu removed the do-not-merge label Jan 9, 2026

Adding further aie4 shim test support #895

Are you sure you want to change the base?

Adding further aie4 shim test support #895

Uh oh!

Conversation

hlaccabu commented Dec 3, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

xdavidz left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hlaccabu commented Jan 6, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hlaccabu commented Jan 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hlaccabu commented Jan 8, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

hlaccabu commented Jan 7, 2026 •

edited

Loading