-
Notifications
You must be signed in to change notification settings - Fork 0
add tests that run locally to test attributes of pvols #143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #143 +/- ##
==========================================
+ Coverage 91.92% 91.94% +0.02%
==========================================
Files 25 25
Lines 1882 1888 +6
==========================================
+ Hits 1730 1736 +6
Misses 152 152 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…ase to update codemeta and cffr
|
@peterdesmet & @PietrH I just discovered the |
|
Currently the local test fail for the use for height this will be resolved with this issue: adokter/vol2birdR#144 |
update to main
Removed conditional skip for Denmark API key in tests.
update from main
|
|
||
| test_that("Check Germany", { | ||
| skip_on_cran() | ||
| skip_on_ci() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why skip on CI?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As i remember the tests can take quite long, if we want to test on CI i think we should avoid doing it on all runners (also to reduce load). These tests are mainly meant to check the data format of the radars so are not likely os dependent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very well, I was just curious. Seems like it should do the trick!
I've once read, I believe in the HTTP testing guide, about setting up a Github Workflow that ran every week instead of every PR to test for this kind of integrity. But I've never actually set something like that up for any of my repo's. I've used postman instead for checking that sort of thing.
Given #139 i thought it would be good to add tests locally where we compare the attributes of a pvol to the meta data of
get_weather_radars. There is no need to always run it so it was designed to run only locally.