Example docker-compose with proxy auth variables #447
Open
drajabr wants to merge 6 commits intoalmarklein:mainfrom
Open
Example docker-compose with proxy auth variables #447drajabr wants to merge 6 commits intoalmarklein:mainfrom
drajabr wants to merge 6 commits intoalmarklein:mainfrom
Conversation
Usually, if someone is using docker for other than local testing will be using a reverse proxy to access applications, and most of the time also for authentication. So added the required environment variables to work with proxy auth.
Added proxy auth variables and changed the default port.
Edit: default docker forwarding port not to colloid with the proxy
almarklein
reviewed
Feb 12, 2024
Owner
almarklein
left a comment
almarklein
left a comment
There was a problem hiding this comment.
Thanks! I made some comments and suggestions. Most also apply to the other file.
Co-authored-by: Almar Klein <almar@almarklein.org>
Co-authored-by: Almar Klein <almar@almarklein.org>
Co-authored-by: Almar Klein <almar@almarklein.org>
Author
|
Even though its a little contribution, but I'm happy for it! Wish I can help more :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added proxy auth variables
Changed docker bind port to 8888 instead of 80, as it will almost always be occupied.