Skip to content

feat: log concurrency configuration at startup for debugging#925

Open
devin-ai-integration[bot] wants to merge 3 commits intomainfrom
devin/1772184954-log-concurrency-level
Open

feat: log concurrency configuration at startup for debugging#925
devin-ai-integration[bot] wants to merge 3 commits intomainfrom
devin/1772184954-log-concurrency-level

Conversation

@devin-ai-integration
Copy link
Contributor

Summary

Adds an info-level log line in ConcurrentDeclarativeSource.__init__ that logs the resolved concurrency configuration at startup. This logs:

  • concurrency_level (the number of worker threads)
  • initial_number_of_partitions_to_generate
  • Whether concurrency_level was defined in the manifest or fell back to the default

This is needed to debug a Google Ads connector deadlock in Airbyte Cloud where the connector hangs deterministically when the num_workers config field is absent, but works when explicitly set to 3 — despite both cases producing identical concurrency levels locally. This log line will confirm the actual concurrency level the connector receives at runtime in the Cloud environment.

Review & Testing Checklist for Human

  • Verify the log line doesn't introduce any performance concerns (it runs once during __init__, so should be negligible)
  • Confirm the log output is useful in Cloud connector logs (visible in the Airbyte Cloud sync log viewer)

Notes

  • Requested by Anatolii Yatsuk (gl_anatolii.yatsuk)
  • Devin session

@devin-ai-integration
Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@github-actions
Copy link

👋 Greetings, Airbyte Team Member!

Here are some helpful tips and reminders for your convenience.

💡 Show Tips and Tricks

Testing This CDK Version

You can test this version of the CDK using the following:

# Run the CLI from this branch:
uvx 'git+https://github.com/airbytehq/airbyte-python-cdk.git@devin/1772184954-log-concurrency-level#egg=airbyte-python-cdk[dev]' --help

# Update a connector to use the CDK from this branch ref:
cd airbyte-integrations/connectors/source-example
poe use-cdk-branch devin/1772184954-log-concurrency-level

PR Slash Commands

Airbyte Maintainers can execute the following slash commands on your PR:

  • /autofix - Fixes most formatting and linting issues
  • /poetry-lock - Updates poetry.lock file
  • /test - Runs connector tests with the updated CDK
  • /prerelease - Triggers a prerelease publish with default arguments
  • /poe build - Regenerate git-committed build artifacts, such as the pydantic models which are generated from the manifest JSON schema in YAML.
  • /poe <command> - Runs any poe command in the CDK environment
📚 Show Repo Guidance

Helpful Resources

📝 Edit this welcome message.

@github-actions
Copy link

github-actions bot commented Feb 27, 2026

PyTest Results (Fast)

597 tests   - 3 272   585 ✅  - 3 272   3m 27s ⏱️ - 3m 24s
  1 suites ±    0    11 💤  -     1 
  1 files   ±    0     1 ❌ +    1 

For more details on these failures, see this check.

Results for commit 4ea2fe0. ± Comparison against base commit 7f41401.

This pull request removes 3272 tests.
unit_tests.sources.declarative.async_job.test_integration.JobDeclarativeStreamTest ‑ test_when_read_then_call_stream_slices_only_once
unit_tests.sources.declarative.async_job.test_integration.JobDeclarativeStreamTest ‑ test_when_read_then_return_records_from_repository
unit_tests.sources.declarative.async_job.test_job.AsyncJobTest ‑ test_given_status_is_terminal_when_update_status_then_stop_timer
unit_tests.sources.declarative.async_job.test_job.AsyncJobTest ‑ test_given_timer_is_not_out_when_status_then_return_actual_status
unit_tests.sources.declarative.async_job.test_job.AsyncJobTest ‑ test_given_timer_is_out_when_status_then_return_timed_out
unit_tests.sources.declarative.async_job.test_job_orchestrator.AsyncJobOrchestratorTest ‑ test_given_exception_on_single_job_when_create_and_get_completed_partitions_then_return
unit_tests.sources.declarative.async_job.test_job_orchestrator.AsyncJobOrchestratorTest ‑ test_given_exception_to_break_when_start_job_and_raise_this_exception_and_abort_jobs
unit_tests.sources.declarative.async_job.test_job_orchestrator.AsyncJobOrchestratorTest ‑ test_given_exception_when_start_job_and_skip_this_exception
unit_tests.sources.declarative.async_job.test_job_orchestrator.AsyncJobOrchestratorTest ‑ test_given_failure_when_create_and_get_completed_partitions_then_raise_exception
unit_tests.sources.declarative.async_job.test_job_orchestrator.AsyncJobOrchestratorTest ‑ test_given_jobs_failed_more_than_max_attempts_when_create_and_get_completed_partitions_then_free_job_budget
…

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Feb 27, 2026

PyTest Results (Full)

3 872 tests   3 859 ✅  11m 18s ⏱️
    1 suites     12 💤
    1 files        1 ❌

For more details on these failures, see this check.

Results for commit 4ea2fe0.

♻️ This comment has been updated with latest results.

@tolik0
Copy link
Contributor

Anatolii Yatsuk (tolik0) commented Feb 27, 2026

/prerelease

Prerelease Job Info

This job triggers the publish workflow with default arguments to create a prerelease.

Prerelease job started... Check job output.

✅ Prerelease workflow triggered successfully.

View the publish workflow run: https://github.com/airbytehq/airbyte-python-cdk/actions/runs/22489445491

@tolik0
Copy link
Contributor

Anatolii Yatsuk (tolik0) commented Feb 27, 2026

/prerelease

Prerelease Job Info

This job triggers the publish workflow with default arguments to create a prerelease.

Prerelease job started... Check job output.

✅ Prerelease workflow triggered successfully.

View the publish workflow run: https://github.com/airbytehq/airbyte-python-cdk/actions/runs/22494697606

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant