Skip to content

Conversation

@agoscinski
Copy link
Collaborator

@agoscinski agoscinski commented Nov 21, 2024

Based on #97

The implementation as in aiida-core. Using an explicit definition of node statistics for better API documentation.

@agoscinski agoscinski requested a review from eimrek November 21, 2024 15:23
@edan-bainglass edan-bainglass force-pushed the nodes-statistics-endpoint branch 2 times, most recently from 671f6de to 9ea717f Compare December 2, 2025 18:05
Copy link
Member

@edan-bainglass edan-bainglass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @agoscinski. I tested this locally and found that it needs access to the DB to gather statistics. Without the with_dbenv decorator, this endpoint, if hit first, raises an error that no profile is loaded. The decorator ensures one is. I've pushed the change.

LGTM!

Copy link
Collaborator Author

@agoscinski agoscinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good to me.

@edan-bainglass edan-bainglass force-pushed the nodes-statistics-endpoint branch 3 times, most recently from 2c55f6a to 84486e1 Compare December 22, 2025 06:37
@edan-bainglass edan-bainglass force-pushed the nodes-statistics-endpoint branch from 84486e1 to 0da6796 Compare December 22, 2025 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants