-
Notifications
You must be signed in to change notification settings - Fork 9
Add /nodes/statistics/user endpoint to REST API
#80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
671f6de to
9ea717f
Compare
edan-bainglass
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @agoscinski. I tested this locally and found that it needs access to the DB to gather statistics. Without the with_dbenv decorator, this endpoint, if hit first, raises an error that no profile is loaded. The decorator ensures one is. I've pushed the change.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes looks good to me.
2c55f6a to
84486e1
Compare
The implementation as in aiida-core.
84486e1 to
0da6796
Compare
Based on #97
The implementation as in aiida-core. Using an explicit definition of node statistics for better API documentation.