Rename repository modules #105
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The implementation as in aiida-core.
edan-bainglass
force-pushed
the
services
branch
3 times, most recently
from
d0b1dad to
9d5d63d
Compare
edan-bainglass
force-pushed
the
services
branch
from
9d5d63d to
3bd7812
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #104
They're services really. A REST repository (which is a typical dependency of a REST service) is actually the entity collection. Appropriately, we inject an entity to these classes and use their collection for repository-like actions. Hence, services.
Peripheral changes
Moved node models from the router to a consolidate node.py module under the models package (including the model registry).