feat: cleanup DNS on FQDN change #166
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adyanth
reviewed
May 17, 2025
| configmap *corev1.ConfigMap | ||
| fallbackTarget string | ||
| cfAPI *cf.API | ||
| removedHostnames []string |
Owner
There was a problem hiding this comment.
Would this have hostnames from all tunnel bindings? I don't particularly like that tbh, where modifying one can result in a cleanup from another binding.
Could we do something per tunnelBinding utilizing status to keep track of previous, and delete them if the spec is changed to a new one?
Contributor
Author
There was a problem hiding this comment.
No, it only holds removed hostnames for a particular tunnelBinding.
But the way the code is put together, the removedHostnames are shared across tunnelBinding reconciliation. This is fine as long as the MaxConcurrentReconciles is not set (defaults to 1) which it is now, and would get problematic if the concurrency is set larger than 1.
StringKe
referenced
this pull request
in StringKe/cloudflare-operator
Jan 7, 2026
Implement comprehensive Cloudflare Zero Trust Kubernetes operator with 18 CRDs: **New CRDs:** - AccessApplication: Zero Trust application definitions - AccessGroup: Reusable access policy groups - AccessIdentityProvider: IdP configurations (OIDC, SAML, GitHub, Azure AD) - AccessServiceToken: Machine-to-machine authentication tokens - VirtualNetwork: Cloudflare virtual networks for traffic isolation - NetworkRoute: IP routes through tunnels to private networks - PrivateService: Expose K8s Services via WARP private IPs - GatewayRule: Gateway DNS/HTTP/network policies - GatewayList: Lists for gateway policy rules - GatewayConfiguration: Global gateway settings - DeviceSettingsPolicy: WARP client settings and split tunnels - DevicePostureRule: Device posture checks for Zero Trust - DNSRecord: DNS record management - WARPConnector: WARP connector deployments **Enhancements:** - Add EnableWarpRouting to Tunnel/ClusterTunnel for private network access - Add cluster-resource-namespace flag with Downward API injection (PR #178) - Store previous-hostnames in TunnelBinding annotation (PR #166) - Fix Secret finalizer order in cleanupTunnel (PR #158) **API Clients:** - Access API: Applications, Groups, Identity Providers, Service Tokens - Gateway API: Rules, Lists, Configurations - Device API: Split Tunnel, Fallback Domains, Posture Rules - Network API: Virtual Networks, Routes - DNS API: Record management 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
StringKe
referenced
this pull request
in StringKe/cloudflare-operator
Jan 7, 2026
Release v0.14.0 with Zero Trust CRDs: - 14 new CRDs for Access, Gateway, Device, and Network management - WARP routing support for private network access - Upstream PR fixes (#178, #166, #158) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #70
Rough idea for getting the hostnames diff between current state and previous state.