ACNA-3510: validate app config by default

[hannah-taub-1]

Description

1. Set validateAppConfig to true by default in the BaseCommand method getFullConfig.
2. Add input flag to set validateAppConfig manually.
3. Ensure that flags are passed into this method no matter the type of command.

Related Issue

https://jira.corp.adobe.com/browse/ACNA-3510

Motivation and Context

How Has This Been Tested?

1. Added debug logs to check for the value of validateAppConfig.
2. Ran multiple commands in a test repo (deploy, logs) to make sure the value was propagating correctly.
3. Updated unit tests to check for true and false validateAppConfig values.

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• I have signed the Adobe Open Source CLA.
• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

[MichaelGoberling]

This is an awesome start. Great job! Couple things here:

• Imo in the description we shouldn't qualify the config-validation flag as only happening before deploying since it happens before other actions now too
• There are still some commands that need to inherit the BaseCommand flags, so far I can see: test, set/get log forwarding, and get log-forwarding errors. I would just double check every command that's using getFullConfig() has the flags defined and are spread from BaseCommand
• Maybe a Q for @shazron - Do we want to use config-validation in pack, or keep it hard-coded to always verify?

[shazron]

Not a comment on your code but previous code: not sure how the previous code worked since it shouldn't. The unit tests didn't catch this https://github.com/adobe/aio-cli-plugin-app/blob/master/test/commands/app/test.test.js