fix: scopes not attached to credentials when adding services #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #85 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 5
Lines 540 543 +3
Branches 90 92 +2
=========================================
+ Hits 540 543 +3 ☔ View full report in Codecov by Sentry. |
purplecabbage
approved these changes
Dec 5, 2024
shazron
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes adobe/aio-cli#697
We were always using credential type of 'entp' when subscribing to services, but it has to be 'oauth_server_to_server' for oauth credentials
I believe the extra code for handling an existing credential is for the case where the user's local config is out of date with the server, but truthfully didn't fully test this, just needed it to make sure the tests passed