Add Waveshare rp2350 USB-A Board#10320
Open
DaveRichmond wants to merge 5 commits intoadafruit:mainfrom
Open
Conversation
Author
|
Just noticed the duplicate usb vid/pid, and waveshare don't appear to have submitted it to rpi yet. Just submitted a ticket to waveshare to hopefully get that submitted so that bit can be fixed. |
b918868 to
5572f0e
Compare
Collaborator
|
@DaveRichmond did you change to a new PID/VID? I wasn't sure. |
Author
|
I did not. Asked waveshare to get one for it from raspberry pi (https://github.com/raspberrypi/usb-pid), but it seems they just ignored me in the end. They've done it for almost everything else they make, just not this one sigh. Without that I'm a bit stuck on how to move forward |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just a pull to add the Waveshare RP2350 USB-A board (https://www.waveshare.com/wiki/RP2350-USB-A)
I have tested the USB host capabilities with the example from the adafruit usb host descriptors library and it appeared to work flawlessly. Onboard LED also appears to be working just fine straight out of the box.
Sorry, haven't done many pull requests in my time, so I'm a little nervous I've forgotten something