auto-refresh config's boutiques descriptor #1174#1365
Open
MontrealSergiy wants to merge 8 commits intoaces:masterfrom
Open
auto-refresh config's boutiques descriptor #1174#1365MontrealSergiy wants to merge 8 commits intoaces:masterfrom
MontrealSergiy wants to merge 8 commits intoaces:masterfrom
Conversation
MontrealSergiy
added
Enhancement
Boutiques
Member
|
Please review my comments. |
Contributor
Author
|
I agree with changes, but not sure will pr work, or at least not causing issues with old style boutiques, I think I'd add some safeguard |
Member
|
Please address my comments that were made three weeks ago! |
MontrealSergiy
force-pushed
the
boutiques_refresh#1174
branch
from
3f9dc01 to
bdeebf0
Compare
prioux
requested changes
Apr 8, 2025
Member
prioux
left a comment
prioux
left a comment
There was a problem hiding this comment.
Minor. I want to remove a feature.
…tiques paths, due to slated deprecation of paths field. aces#1174
MontrealSergiy
force-pushed
the
boutiques_refresh#1174
branch
from
44e7728 to
d9c125d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-refresh tool config boutiques descriptor by checking the json file timestap.
Not sure how well scales. Perhaps create race conditions (task started with old boutiques, then post-processed to a recent one), well, that may happen with current codebase too
resolves #1174