This repository was archived by the owner on Jun 12, 2019. It is now read-only.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for the great gem!
I propose exposing the
Google::APIClientobjectclientviaattr_readerfor the following:Why?
The above enable a BigQuery user to easily download a temporary table from Google Cloud storage.
Example:
If you find the above scenario valid for this project, one option is expanding the initial authorization scope to
cloud-platforminstead ofbigquery? Another is rolling in aBigQuery::Client::Downloadmodule which seems out of scope for this gem? Thoughts?I'm happy to provide additional PRs if needed.
Thanks!