Improve SPDX import by generating generic PURLs when missing#2049
Open
Monal-Reddy wants to merge 1 commit intoaboutcode-org:mainfrom
Open
Improve SPDX import by generating generic PURLs when missing#2049Monal-Reddy wants to merge 1 commit intoaboutcode-org:mainfrom
Monal-Reddy wants to merge 1 commit intoaboutcode-org:mainfrom
Conversation
Signed-off-by: Monal-Reddy <monalreddy001@gmail.com>
Author
|
For reference, here is the result after applying this fix locally. Packages previously classified as pkg:unknown/* are now resolved as pkg:generic/* when loading the Python 3.13.9 SPDX SBOM via load_sbom. Image I found this an interesting area, if this looks good to you, i'd be happy to work on the subsequent issues as u have mentioned |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1914
This PR improves the
load_sbompipeline handling of SPDX SBOMs by generating a fallbackpkg:genericPURL when an SPDX package does not provide an explicit PURL but does include a name and version.This avoids classifying such packages as
pkg:unknown, improving package typing and downstream reporting for SPDX-based Python SBOMs.Tested locally using ScanCode.io with:
load_sbompipelinePreviously affected packages such as CPython, expat, libb2, and mpdecimal are now correctly represented as
pkg:generic/*.