Fix D2D mapping for Java class names differing from source filename #2027
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a Java source file contains class declarations with names different from the filename (e.g., DelombokTask.java containing class Tasks), the compiled .class file uses the class name (Tasks.class), not the filename. This fix: - Extracts class/interface/enum names from Java source files during scanning - Stores class names in extra_data["java_classes"] - Indexes both filename-based and class-name-based paths for matching - Enables correct D2D mapping for these edge cases Closes aboutcode-org#1993 Signed-off-by: Mrityunjay Raj <mr.raj.earth@gmail.com>
mr-raj12
force-pushed
the
fix-java-class-mapping
branch
from
a9c801c to
557ce0c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
extra_data["java_classes"]Problem
When a Java source file contains class declarations with names different from the filename (e.g.,
DelombokTask.javacontainingclass Tasks), the compiled.classfile uses the class name (Tasks.class), not the filename. The D2D mapping was failing to find the source file for these cases.Test plan
test_jvm.pytest_d2d.pyCloses #1993
Signed-off-by: Mrityunjay Raj mr.raj.earth@gmail.com