Fix package_content conversion error when adding packages from PurlDB#472
Open
Kaushik-Kumar-CEG wants to merge 1 commit intoaboutcode-org:mainfrom
Open
Conversation
Signed-off-by: Kaushik <kaushikrjpm10@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #467
Issue
PurlDB returns
package_contentas a string (e.g., "binary"), but Django expects an integer. When conversion failed, the old code assignedNoneto the IntegerField, causing:Field 'package_content' expected a number but got None.Solution
Added
Nonechecks after conversion. If conversion fails, remove the field instead of assigningNone, letting Django use the default null value.Changes Made
component_catalog/models.py(line 2663): Addedif package_content_value is not None:checkcomponent_catalog/views.py(line 1939): Added explicitis not NonecheckNoneVerification
Tested locally with scripts simulating PurlDB responses.
Before Fix:
After Fix:
