Skip to content

Conversation

@sacOO7
Copy link
Collaborator

@sacOO7 sacOO7 commented Nov 25, 2025

  • Fix unity build script
  • Fix msgpack deps

TODO

  • Update newtonsoft DLL
  • Update netframework newtonsoft LICENSE

@coderabbitai
Copy link

coderabbitai bot commented Nov 25, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/msgpack-dependencies

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot temporarily deployed to staging/pull/1324/features November 25, 2025 16:36 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1324/features November 25, 2025 18:22 Inactive
Copy link

@tigran-sargsyan-w tigran-sargsyan-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review

Overall this is a solid step towards making the Unity + MsgPack setup more maintainable and IL2CPP‑friendly.

What looks good

  • New Deps and LicenseHelper helpers keep build / license logic out of the main Cake scripts and are easy to reuse.
  • Explicit dependency checks with clear error messages should make missing DLL issues much easier to diagnose in CI and on dev machines.
  • Unity edit/play mode tests being wired into the MsgPack setup helps ensure the Unity path stays in sync with the core library.

Questions / suggestions

  1. In DownloadLicenseContent you create a new HttpClient per call and block on .Result. For build scripts this is usually fine, but it might be safer to either reuse a single HttpClient instance or at least document that the build requires network access to GitHub and these URLs.
  2. When a dependency is missing or a license download fails, the thrown Exception currently stops the build (which is good), but it could be helpful to hint which script/target was running (e.g. include more context in the message) to simplify debugging.
  3. Since this PR is still marked as draft and there are TODOs about updating the Newtonsoft DLL and .NET Framework license, it might be worth adding a short comment in the Cake tasks to make it obvious that those parts are intentionally left for a follow‑up commit.

Once the remaining TODO items are addressed, this looks good to me. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants