Expansion_pvalues #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #39 +/- ##
==========================================
+ Coverage 92.64% 92.77% +0.13%
==========================================
Files 33 34 +1
Lines 2405 2450 +45
==========================================
+ Hits 2228 2273 +45
Misses 177 177
🚀 New features to boost your workflow:
|
colganwi
requested changes
Nov 5, 2025
Collaborator
colganwi
left a comment
colganwi
left a comment
There was a problem hiding this comment.
@isabellechan089 great job on this PR! I just have some nit picky comments about consistency with other Pycea functions. Once these are addressed this will be ready to merge.
Also please remember to update the unreleased section of the changelog.
Collaborator
|
@isabellechan089 let's call this function expansion_test for constancy with #40 |
colganwi
approved these changes
Nov 13, 2025
Collaborator
colganwi
left a comment
colganwi
left a comment
There was a problem hiding this comment.
Thanks @isabellechan089. I've updated the docs and made some minor changes. If everything looks good you can merge this in.
…into expansion_pvalues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adopted from Cassiopeia