Tsclientlib and language option

[cehan-Chloe]

Divided into two commits

1. add ts clientlib for swapi
2. as ts language option

[magicmark]

do you know why the file formatting changed on this? probably fine but just curious if there's a new version of prettier or eslint or something causing all this (e.g. what's causing ' -> "?)

[cehan-Chloe]

not quite sure about this... prettier versions are not updated. how could we test if this will be an issue

[magicmark]

I know the status quo uses the url import but tbh this is probably a mistake, this is easy using stdlib (available as of node v10)

try the following in a node repl:

new URL('/people/123', 'https://swapi.dev/api/');

or if you don't want to rely on a magic .toString()

(new URL('/people/123', 'https://swapi.dev/api/')).href

[magicmark]

nit: enum is fine i guess, but I think a union would be more idiomatic

Suggested change

	export enum LanguageOptions {
	FLOW = 'flow',
	TYPESCRIPT = 'typescript',
	}
	export type LanguageOption = 'flow' | 'typescript';

[magicmark]

(also note the LanguageOptions -> LanguageOption (singular), since there's only one one option being decided here (the target language)

[magicmark]

fwiw, this file is called genTypeFlow.ts implying this is specific for generating types for flow. in my mind, for doing typescript type generation, we'd just copy and paste this whole file and start again making it only typescript focused (rather than having each individual function do a little if statement to check are we generating for flow or typescript)

with that in mind, the choice of 'flow' here would be implicit and not needed as an argument

[cehan-Chloe]

if we use separate genTypeFlow and genTypeTypesciprt, then we could move to codegen function check if the language option is flow or typescript. but in implementations, we'll probably still can't avoid these little if statements.. any suggestions?

export default function codegen(
    /**
     * The user specified config object, defining the shape and behaviour of
     * the resources. May be arbitrarily nested, hence the 'any' type.
     * (Read from dataloader-config.yaml)
     */
    config: GlobalConfig,
   ...
) {
...
if config.language == typescript {
 output = getTypescriptLoaders()
} 
else {
 output = getFlowLoaders()
}
}

[magicmark]

looking good! I think we can continue to add to this PR (or if you want to split things up, feel free to start a new branch or fork that we can merge to)