-
Notifications
You must be signed in to change notification settings - Fork 10
Create AppModulesConventions.md #121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
latata
wants to merge
1
commit into
master
Choose a base branch
from
app-js-modules
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,105 @@ | ||
| # Wikia App JavaScript modules conventions | ||
|
|
||
| This styleguide defines the JavaScript modules strucutre conventions for Wikia App (https://github.com/Wikia/app). | ||
|
|
||
| ## TOC | ||
|
|
||
| * [Files/directories structure](#filesdirectories-structure) | ||
| * [Entry point files](#entry-point-files) | ||
| * [Modules](#modules) | ||
| * [Tracking](#tracking) | ||
|
|
||
|
|
||
| ## Files/directories structure | ||
|
|
||
| ### Keep all JS in scripts folder | ||
|
|
||
| Keep all JavaScript files in `scripts` folder which should be located in extension's root directory (`extensions/wikia/MyExtensions/scripts`) | ||
|
|
||
| ### Entry-point files | ||
|
|
||
| All entry points file-names should start with `index.`. If there is only one entry point file it should be named `index.js` | ||
|
|
||
| ```javascript | ||
| // bad | ||
| foo.js | ||
| entry.js | ||
| start.js | ||
| moduleName.js | ||
|
|
||
| // good | ||
| index.js | ||
|
|
||
| // good only if there are more than one entry point files | ||
| index.example.js | ||
| index.foo.js | ||
| ``` | ||
|
|
||
| ## Entry point files | ||
|
|
||
| ### Keep them small | ||
|
|
||
| Keep entry point files as small as possible. They should usually just execute some initialization functions from other files. | ||
| ``` | ||
| TODO: what if we want to have just one js file in extension? | ||
| ``` | ||
|
|
||
| ## Modules | ||
|
|
||
| ### Name should start with extension name | ||
|
|
||
| Each defined Modil module name should start with extension name prefix. | ||
|
|
||
| ```javascript | ||
| // bad | ||
| define('tracking', ['dependency'], function (dependency) {}); | ||
|
|
||
| // good | ||
| define('MyExtensionName.tracking', ['dependency'], function (dependency) {}); | ||
| ``` | ||
|
|
||
| Read more here: https://github.com/Wikia/guidelines/blob/master/JavaScript/CodingConventions.md#amd-modules | ||
|
|
||
| ### Define module as class | ||
|
|
||
| JS module should be define as class. Currently we use ES5 so should define them using `function` keyword. | ||
|
|
||
| ```javascript | ||
| // good | ||
| define('MyExtensionName.tracking', ['dependency'], function (dependency) { | ||
| function Tracking () { | ||
| // constructor | ||
| } | ||
|
|
||
| Tracking.prototype.myInstanceMethod = function () { | ||
| // public non-static method | ||
| }; | ||
|
|
||
| Tracking.myStaticFunction = function () { | ||
| // public static method | ||
| }; | ||
|
|
||
| function _myPrivateFunction () { | ||
| // private function | ||
| } | ||
|
|
||
| return Tracking; | ||
| }); | ||
| ``` | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. in case we have static methods only do we want to have convention regarding over as well? |
||
|
|
||
| ### Private function names should start with underscore | ||
|
|
||
| All private function should start with underscore (`_`). | ||
|
|
||
| ```javascript | ||
| // bad | ||
| function myPrivateFunction () {} | ||
|
|
||
| // good | ||
| function _myPrivateFunction () {} | ||
| ``` | ||
|
|
||
| ## Tracking | ||
|
|
||
| Keep all tracking in separated file(s). Tracking file-names should start with `tracking.`. If there is only one file that contains tracking functionality it should be named `tracking.js`. | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what would be the case when we 'want' such solution?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there is no need to create multiple files if we want to for example add just one button click handler.