Skip to content

[GStreamer][Broadcom] fix incorrect casting of GstGhostPad to GstElement #1596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
emutavchi wants to merge 1 commit into
base: wpe-2.46
Choose a base branch
from
+3 −3
Open

[GStreamer][Broadcom] fix incorrect casting of GstGhostPad to GstElement #1596

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2166,7 +2166,7 @@ void MediaPlayerPrivateGStreamer::handleMessage(GstMessage* message)
}
}

if (quirksManager.isEnabled() && quirksManager.needsBufferingPercentageCorrection())
if (quirksManager.isEnabled() && quirksManager.needsBufferingPercentageCorrection() && !(isMediaSource() || isMediaStreamPlayer()))
quirksManager.setupBufferingPercentageCorrection(this, currentState, newState, GRefPtr<GstElement>(GST_ELEMENT(GST_MESSAGE_SRC(message))));

if (!messageSourceIsPlaybin || m_isDelayingLoad)
Expand Down
4 changes: 2 additions & 2 deletions Source/WebCore/platform/gstreamer/GStreamerQuirkBroadcomBase.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ void GStreamerQuirkBroadcomBase::setupBufferingPercentageCorrection(MediaPlayerP
GRefPtr<GstPad> peerSrcPad = adoptGRef(gst_pad_get_peer(sinkPad));
if (!peerSrcPad)
continue; // And end the loop, because there's only one srcpad.
GRefPtr<GstElement> peerElement = adoptGRef(GST_ELEMENT(gst_pad_get_parent(peerSrcPad.get())));
GRefPtr<GstElement> peerElement = adoptGRef(gst_pad_get_parent_element(peerSrcPad.get()));

// If it's NOT a multiqueue, it's probably a parser like aacparse. We try to traverse before it.
if (peerElement && g_strcmp0(G_OBJECT_TYPE_NAME(element.get()), "GstMultiQueue")) {
Expand All @@ -150,7 +150,7 @@ void GStreamerQuirkBroadcomBase::setupBufferingPercentageCorrection(MediaPlayerP
if (!peerSrcPad)
continue; // And end the loop.
// Now we hopefully have peerElement pointing to the multiqueue.
peerElement = adoptGRef(GST_ELEMENT(gst_pad_get_parent(peerSrcPad.get())));
peerElement = adoptGRef(gst_pad_get_parent_element(peerSrcPad.get()));
break;
}
}
Expand Down