[WIP] Initial dump for Web Inspector Site Isolation Explainer#133
Open
burg wants to merge 1 commit intoWebKit:mainfrom
Open
[WIP] Initial dump for Web Inspector Site Isolation Explainer#133burg wants to merge 1 commit intoWebKit:mainfrom
burg wants to merge 1 commit intoWebKit:mainfrom
Conversation
Second editing session adds more details about Target system.
burg
force-pushed
the
eng/bburg/1209-inspector-site-isolation
branch
from
4adf9cc to
4842b9a
Compare
|
|
||
| ## What are the main changes are being proposed? | ||
|
|
||
| - [X] Add new `Frame` target type which represents a place that commands can be targeted at. A Page target has one or more Frame targets. |
Member
There was a problem hiding this comment.
A Page target has one or more Frame targets.
I don't think it's accurate to say this, as there's no hierarchy between the targets, unlike in DOM. We don't mean to let Page targets "own" Frame targets, and we certainly don't plan to expose the remote pages as Page targets to own its Frames. The Page and Frame targets' co-existence is merely a consequence of the slow transition, and our plan is to remove Page targets altogether
Unless you meant "A WebPage target has one or more Frame targets", which I wouldn't consider precise either—the WebPage target reports creation and deletion of Frame targets, not own them, correct?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a draft and will be revised prior to pushing to prod.
(removed unhelpful commit template for now)